Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests that need CUDA to test_operations.py. #6160

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

ysiraichi
Copy link
Collaborator

This PR moves tests introduced in #6060 and #6071 from test_core_aten_ops.py to test_operations.py. This change is needed since test_core_aten_ops.py executes only with PJRT_DEVICE=CPU.

@ysiraichi ysiraichi requested a review from JackCaoG December 14, 2023 19:06
@ysiraichi
Copy link
Collaborator Author

I'm temporarily turning CUDA support for PyTorch on, so that we can run these tests. This is causing problems, as suggested in #6076.

@ysiraichi
Copy link
Collaborator Author

Maybe it'll be better to wait for #6070

@ysiraichi ysiraichi force-pushed the ysiraichi/move-tests branch from ec3f374 to 748c168 Compare February 1, 2024 11:20
@ysiraichi ysiraichi merged commit 16b6bd1 into master Feb 1, 2024
18 checks passed
amithrm pushed a commit to amithrm/xla that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants